Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gtk gtk
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,540
    • Issues 1,540
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 223
    • Merge requests 223
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gtkgtk
  • Merge requests
  • !119

Gtkplacesview finalization fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Trevisan requested to merge 3v1n0/gtk:gtkplacesview-finalization-fixes-master into master Apr 19, 2018
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 1

When destroying this widget we could have this warning:

GLib-CRITICAL **: 23:06:12.109: Source ID 1925 was not found when attempting to remove it

Or a crash (or warning once !117 (merged) is merged) because populate_servers could be called in between the disposition and finalization (see ubuntu bug, fedora bug or nautilus#140 (closed)).

Edited Apr 19, 2018 by Marco Trevisan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gtkplacesview-finalization-fixes-master