[patches] ComboBox: Improve positioning of menu in grid and custom-child modes
Submitted by Daniel Boles
Currently, when opening a ComboBox in one of these modes, the menu pops up at the far left. This means two things:
The user has to move their mouse again, to get to the menu, rather than it appearing nearby.
Even if we must fix the position, opening at the left seems especially weird, since the arrow indicating the drop-down nature of the widget is at the far right.
My suggestions, which I have implemented, are as follows:
If we're in grid mode and get a mouse click/tap, then open the menu at the pointer, but offset such that the active item ends up being under the pointer. This lets the user most efficiently navigate from the current item to their choice - no flying to the other side needed.
If we're in custom-child mode, or grid mode with keyboard, then open the menu at the right by the arrow, instead of at the left of the entire widget.
Do you agree that these sound sensible and improve on the current behaviour?
Patches on the way once I clean them up.