[gtk3, gtk4] testsuite/reftests/flipping-icons.* fails with current adwaita-icon-theme
GTK3's testsuite/reftests/flipping-icons.*
seems to be there to assert that certain pairs of leftward- and rightward-facing icons swap their direction in RTL locales. media-skip-backward
and media-skip-forward
are one of these pairs, and media-seek-forward
and media-seek-backward
are another.
This was indeed what happened in older Adwaita versions, but that behaviour was considered to be wrong (adwaita-icon-theme#75 (closed)) and was removed. As a result, this reftest now fails. It is allowed to fail in the Meson build system, but not in the Autotools build system.
Two possible solutions:
- Change this reftest so it doesn't make any particular assertion about fast-forward/rewind icons
- Change this reftest so it asserts that fast-forward/rewind icons are not flipped, and document a new dependency on adwaita-icon-theme >= 3.36
This reftest can probably be removed from somehow_broken
in testsuite/reftests/meson.build
after this has been fixed.
Downstream bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954584
Thanks to @bigon who pointed out which Adwaita change is likely to have triggered this.
I haven't tried it with GTK4, but git diff
says GTK4 almost certainly has the same bug.