Race in gsk/testsuite/compare-render
Here's the relevant output:
--- stderr ---
** (compare-render:8838): ERROR **: 18:54:29.327: Failed to create output dir: Error creating directory /builds/GNOME/gtk/_build/testsuite/gsk/compare/opengl: File exists
What happens is that tests run in parallel, 2 tests enter get_output_dir()
at the same time and realize the output dir doesn't exist yet, then they both try to create it, one of them wins and the other gets the above error.
Filing this here because I have no idea what the proper way to code this is.
Just always create the directory and skip G_IO_ERROR_EXISTS
?
Is the g_file_test_exists()
check necessary?
Something else?
Are there other tests that need this fixed?
Can someone cc the parallel file-operation specialist who knows about this?