gtk+ 3.24.5: fribidi compile issue
Looks like changes in last gtk+ are bit deeper than those described in NEWS file. Gtk+ build fails on
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/gtk+-3.24.5/gdk/wayland' /bin/sh ../../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../.. -DG_LOG_DOMAIN=\"Gdk\" -DG_LOG_USE_STRUCTURED=1 -DGDK_COMPILATION -I../.. -I../../gdk -I../../gdk -fvisibility=hidden -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS -DG_DISABLE_CAST_CHECKS -DGLIB_MIN_REQUIRED_VERSION=GLIB_VERSION_2_52 -DGLIB_MAX_ALLOWED_VERSION=GLIB_VERSION_2_54 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -pthread -I/usr/include/gio-unix-2.0/ -I/usr/include/libdrm -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -c -o gdkkeys-wayland.lo gdkkeys-wayland.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../.. -DG_LOG_DOMAIN=\"Gdk\" -DG_LOG_USE_STRUCTURED=1 -DGDK_COMPILATION -I../.. -I../../gdk -I../../gdk -fvisibility=hidden -DG_DISABLE_ASSERT -DG_DISABLE_CHECKS -DG_DISABLE_CAST_CHECKS -DGLIB_MIN_REQUIRED_VERSION=GLIB_VERSION_2_52 -DGLIB_MAX_ALLOWED_VERSION=GLIB_VERSION_2_54 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -pthread -I/usr/include/gio-unix-2.0/ -I/usr/include/libdrm -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -c gdkkeys-wayland.c -fPIC -DPIC -o .libs/gdkkeys-wayland.o gdkkeys-wayland.c:34:10: fatal error: fribidi.h: No such file or directory 34 | #include <fribidi.h> | ^~~~~~~~~~~ compilation terminated. make[1]: *** [Makefile:742: gdkkeys-wayland.lo] Error 1
fribidi headers paths are in:
$ grep fribidi Makefile BASE_DEPENDENCIES_CFLAGS = -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0 -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/gdk-pixbuf-2.0 -pthread BASE_DEPENDENCIES_LIBS = -latk-1.0 -lpango-1.0 -lfribidi -lcairo-gobject -lcairo -lpixman-1 -lfontconfig -lfreetype -lpng16 -lz -lxcb-shm -lxcb -lxcb-render -lXrender -lX11 -lXext -lgdk_pixbuf-2.0 -lgobject-2.0 -lglib-2.0
but none of the *_CFLAGS in gdk/wayland/Makefile.am is using it.
Just checked and looks like up to now fribidi was not used by gtk+ 3.x
$ rpm -q --whatrequires 'libfribidi.so.0()(64bit)' clutter-1.26.2-7.fc29.x86_64 gspell-devel-1.8.1-2.fc29.x86_64 gnome-system-log-3.9.90-12.fc29.x86_64 libpeas-devel-1.22.0-9.fc29.x86_64 libappindicator-gtk3-12.10.0-20.fc29.x86_64 lasi-1.1.2-11.fc29.x86_64 libpeas-gtk-1.22.0-9.fc29.x86_64 fribidi-1.0.5-2.fc30.x86_64 gnome-autoar-0.2.3-2.fc29.x86_64 libcanberra-gtk3-0.30-17.fc29.x86_64 gspell-1.8.1-2.fc29.x86_64 clutter-gst3-3.0.26-2.fc29.x86_64 dia-0.97.3-10.fc29.x86_64 gnome-screensaver-3.6.1-21.fc29.x86_64 libdbusmenu-gtk3-16.04.0-8.fc29.x86_64 clutter-gtk-1.8.4-4.fc29.x86_64 pango-1.43.0-2.fc30.x86_64 goocanvas2-2.0.4-3.fc29.x86_64 pygtk2-2.24.0-23.fc29.x86_64 libcanberra-gtk2-0.30-17.fc29.x86_64 mousetweaks-3.12.0-10.fc29.x86_64 adwaita-gtk2-theme-3.28-2.fc29.x86_64 gtk2-devel-2.24.32-3.fc29.x86_64 fribidi-devel-1.0.5-2.fc30.x86_64 gtk2-2.24.32-3.fc29.x86_64