Skip to content
  • António Fernandes's avatar
    listbase: Don't start rubberband on ::drag-end · dc4540fa
    António Fernandes authored
    GtkGestrureDrag::drag-end can be emitted when the pointer has just
    crossed the drag threshold and we have not started the rubberband yet.
    This happens if another gesture has claimed the event sequence earlier
    in the current event propagation chain.
    
    In such situation, our ::drag-end calls gtk_list_base_drag_update(), 
    which proceeds to start the rubberband. That's obviously wrong.
    Additionally, it also tries to get modifiers from an event it we are 
    already denied,  which obviously fails with criticals:
    
    `gdk_event_get_modifier_state: assertion 'GDK_IS_EVENT (event)' failed`
    
    Thus, if there is no rubberband when we receive ::drag-end, do nothing.
    dc4540fa