API bugs
@hadess
Submitted by Bastien Nocera Assigned to gri..@..e.bugs
Link to original bug (#749891)
Description
grl_operation_options_get_count() can never return a negative value, so should return a guint. This would fix the following coverity warnings:
33. grilo-0.2.12/libs/pls/grl-pls.c:613: negative_return_fn: Function "grl_operation_options_get_count(bs->options)" returns a negative number.
36. grilo-0.2.12/src/grl-operation-options.c:416:3: return_negative_constant: Explicitly returning negative value "-1".
37. grilo-0.2.12/libs/pls/grl-pls.c:613: var_assign: Assigning: unsigned variable "count" = "grl_operation_options_get_count".
44. grilo-0.2.12/libs/pls/grl-pls.c:630: negative_returns: Using unsigned variable "count" in a loop exit condition.
# 628| int i;
# 629|
# 630|-> for (i = 0;i < count;i++) {
# 631| GrlMedia *content;
# 632|
33. grilo-0.2.12/libs/pls/grl-pls.c:613: negative_return_fn: Function "grl_operation_options_get_count(bs->options)" returns a negative number.
36. grilo-0.2.12/src/grl-operation-options.c:416:3: return_negative_constant: Explicitly returning negative value "-1".
37. grilo-0.2.12/libs/pls/grl-pls.c:613: var_assign: Assigning: unsigned variable "count" = "grl_operation_options_get_count".
41. grilo-0.2.12/libs/pls/grl-pls.c:617: var_assign: Assigning: unsigned variable "remaining" = "count".
45. grilo-0.2.12/libs/pls/grl-pls.c:630: negative_returns: Using unsigned variable "count" in a loop exit condition.
# 628| int i;
# 629|
# 630|-> for (i = 0;i < count;i++) {
# 631| GrlMedia *content;
# 632|
Version: git master
Edited by Marinus Schraal