GitLab

=========================================
   gparted 1.2.0: tests/test-suite.log
=========================================

# TOTAL: 5
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test_PipeCapture
======================

Running main() from src/gtest_main.cc
[==========] Running 13 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 13 tests from PipeCaptureTest
[ RUN      ] PipeCaptureTest.EmptyPipe
[       OK ] PipeCaptureTest.EmptyPipe (0 ms)
[ RUN      ] PipeCaptureTest.EmptyPipeWithEOF
[       OK ] PipeCaptureTest.EmptyPipeWithEOF (0 ms)
[ RUN      ] PipeCaptureTest.ShortASCIIText
[       OK ] PipeCaptureTest.ShortASCIIText (0 ms)
[ RUN      ] PipeCaptureTest.LongASCIIText
[       OK ] PipeCaptureTest.LongASCIIText (36 ms)
[ RUN      ] PipeCaptureTest.LongASCIITextWithUpdate
[       OK ] PipeCaptureTest.LongASCIITextWithUpdate (27 ms)
[ RUN      ] PipeCaptureTest.MinimalBinaryCrash777973
[       OK ] PipeCaptureTest.MinimalBinaryCrash777973 (0 ms)
[ RUN      ] PipeCaptureTest.ReadEmbeddedNULCharacter
test_PipeCapture.cc:336: Failure
      Expected: inputstr
     Of length: 6
To be equal to: capturedstr.raw()
     Of length: 5
With first binary difference:
< 0x00000000  "ABC.EF"            41 42 43 00 45 46
--
> 0x00000000  "ABCEF"             41 42 43 45 46
[  FAILED  ] PipeCaptureTest.ReadEmbeddedNULCharacter (0 ms)
[ RUN      ] PipeCaptureTest.ReadNULByteInMiddleOfMultiByteUTF8Character
test_PipeCapture.cc:353: Failure
      Expected: expectedstr
     Of length: 7
To be equal to: capturedstr.raw()
     Of length: 6
With first binary difference:
< 0x00000000  "._45678"           00 5F 34 35 36 37 38
--
> 0x00000000  "_45678"            5F 34 35 36 37 38
[  FAILED  ] PipeCaptureTest.ReadNULByteInMiddleOfMultiByteUTF8Character (0 ms)
[ RUN      ] PipeCaptureTest.LineDisciplineCarriageReturn
[       OK ] PipeCaptureTest.LineDisciplineCarriageReturn (0 ms)
[ RUN      ] PipeCaptureTest.LineDisciplineCarriageReturn2
[       OK ] PipeCaptureTest.LineDisciplineCarriageReturn2 (0 ms)
[ RUN      ] PipeCaptureTest.LineDisciplineBackspace
[       OK ] PipeCaptureTest.LineDisciplineBackspace (1 ms)
[ RUN      ] PipeCaptureTest.LineDisciplineBackspace2
[       OK ] PipeCaptureTest.LineDisciplineBackspace2 (0 ms)
[ RUN      ] PipeCaptureTest.LineDisciplineSkipCtrlAB
[       OK ] PipeCaptureTest.LineDisciplineSkipCtrlAB (0 ms)
[----------] 13 tests from PipeCaptureTest (66 ms total)

[----------] Global test environment tear-down
[==========] 13 tests from 1 test case ran. (66 ms total)
[  PASSED  ] 11 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] PipeCaptureTest.ReadEmbeddedNULCharacter
[  FAILED  ] PipeCaptureTest.ReadNULByteInMiddleOfMultiByteUTF8Character

 2 FAILED TESTS
FAIL test_PipeCapture (exit status: 1)

============================================================================
Testsuite summary for gparted 1.2.0
============================================================================
# TOTAL: 5
# PASS:  4
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to https://gitlab.gnome.org/GNOME/gparted/issues
============================================================================
make[3]: *** [Makefile:887: test-suite.log] Error 1
make[3]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/gparted-1.2.0/tests'
make[2]: *** [Makefile:995: check-TESTS] Error 2
make[1]: *** [Makefile:1097: check-am] Error 2
make: *** [Makefile:629: check-recursive] Error 1

BTW would you consider change tagging convention from GPARTED_<version_with_underscores> to just <version_with_dots> to martch actual version string?

Current tagging convention is causing that tagged git tar balls provided by gitlab res interface have odd base directory (gitlab/github automatically adds to base directory repo name). You can have look on to check this out https://gitlab.gnome.org/GNOME/gparted/-/archive/GPARTED_1_2_0/gparted-GPARTED_1_2_0.tar.bz2