Skip to content

gom-resource: Don’t connect to primary key notifications if unset

Philip Withnall requested to merge pwithnall/gom:notify-naming into master

If no primary key is set, don’t try and connect to notifications for it. With recent versions of GLib (since 2.63.3) it will emit a critical warning if a signal name passed to g_signal_connect() is invalid.

If no primary key was set, GOM was passing notify:: as the signal name, which is invalid.

This was causing the runtime warning:

Bail out! GLib-GObject-FATAL-WARNING: ../../../gobject/gsignal.c:2617: signal 'notify::' is invalid for instance '0x562bad15db90' of type 'GomResource'

Signed-off-by: Philip Withnall withnall@endlessm.com

Merge request reports