Skip to content

pkgconfig.libs: filter out m.lib

Tom Schoonjans requested to merge tschoonj/gobject-introspection:pkgconfig-fix into main

We recently ran into trouble creating the gobject-introspection bindings for librsvg.

(%BUILD_PREFIX%) %SRC_DIR%\win32>echo ..\librsvg\librsvg-features.h  1>>vs15\release\x64\librsvg\Rsvg_2_0_gir_list 
Generating vs15\release\x64\Rsvg-2.0.gir...
	python %BUILD_PREFIX%\Library\bin\g-ir-scanner	 --verbose -no-libtool	 --namespace=Rsvg	 --nsversion=2.0	 --pkg=pango --extra-library=libxml2	 --library=rsvg-2.0	 --add-include-path=%BUILD_PREFIX%\Library\bin\..\share\gir-1.0	 --include=GLib-2.0 --include=GObject-2.0	 --include=Gio-2.0 --include=cairo-1.0	 --include=GdkPixbuf-2.0	 --pkg-export=librsvg-2.0	 --cflags-begin	 -I..				 -I.\vs15\release\x64\librsvg		 -I%PREFIX%\Library\include\gdk-pixbuf-2.0	 -I%PREFIX%\Library\include\pango-1.0	 -I%PREFIX%\Library\include\gio-win32-2.0	 -I%PREFIX%\Library\include\glib-2.0	 -I%PREFIX%\Library\lib\glib-2.0\include	 -I%PREFIX%\Library\include\harfbuzz	 -I%PREFIX%\Library\include		 -I%PREFIX%\Library\include\libxml2 -DRSVG_COMPILATION	 -utf-8	 --cflags-end	 --c-include=librsvg/rsvg.h	 --filelist=vs15\release\x64\librsvg\Rsvg_2_0_gir_list	 -L.\vs15\release\x64 -L%PREFIX%\Library\lib -L%BUILD_PREFIX%\Library\bin	 -o vs15\release\x64\Rsvg-2.0.gir
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\cl.exe -E -P -C -utf-8 -DRSVG_COMPILATION -D_USE_DECLSPECS_FOR_SAL -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_WARNINGS -DSAL_NO_ATTRIBUTE_DECLARATIONS -I. -I%SRC_DIR% -I%SRC_DIR%\win32\vs15\release\x64\librsvg -I%PREFIX%\Library\include\gdk-pixbuf-2.0 -I%PREFIX%\Library\include\pango-1.0 -I%PREFIX%\Library\include\gio-win32-2.0 -I%PREFIX%\Library\include\glib-2.0 -I%PREFIX%\Library\lib\glib-2.0\include -I%PREFIX%\Library\include\harfbuzz -I%PREFIX%\Library\include -I%PREFIX%\Library\include\libxml2 -I%PREFIX%\Library\include\cairo -I%PREFIX%\Library\include\fribidi -I%PREFIX%\Library\include\libxml -I%PREFIX%\Library\include\freetype2 -I%PREFIX%\Library\include\libpng16 %SRC_DIR%\win32\g-ir-cpp-t463wc1k.c
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045 for x64
Copyright (C) Microsoft Corporation.  All rights reserved.

g-ir-cpp-t463wc1k.c
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\bin\HostX64\x64\cl.exe /c /nologo /Ox /MD /W3 /GS- /DNDEBUG -DRSVG_COMPILATION -I%PREFIX%\Library\include\cairo -I%PREFIX%\Library\include\pango-1.0 -I%PREFIX%\Library\include\fribidi -I%PREFIX%\Library\include -I%PREFIX%\Library\include\libxml -I%PREFIX%\Library\include\cairo -I%PREFIX%\Library\include\harfbuzz -I%PREFIX%\Library\include\freetype2 -I%PREFIX%\Library\include\libpng16 -I%PREFIX%\Library\include -I%PREFIX%\Library\include\gdk-pixbuf-2.0 -I%PREFIX%\Library\include -I%PREFIX%\Library\include\glib-2.0 -I%PREFIX%\Library\lib\glib-2.0\include -I%PREFIX%\Library\include -I%PREFIX%\Library\include -I%PREFIX%\Library\include\pango-1.0 -I%PREFIX%\Library\include -I%PREFIX%\Library\include\fribidi -I%PREFIX%\Library\include -I%PREFIX%\Library\include\libxml -I%PREFIX%\Library\include\cairo -I%PREFIX%\Library\include -I%PREFIX%\Library\include\harfbuzz -I%PREFIX%\Library\include\freetype2 -I%PREFIX%\Library\include\libpng16 -I%PREFIX%\Library\include -I%PREFIX%\Library\include\glib-2.0 -I%PREFIX%\Library\lib\glib-2.0\include -I%PREFIX%\Library\include -I%SRC_DIR% -I%SRC_DIR%\win32\vs15\release\x64\librsvg -I%PREFIX%\Library\include\gdk-pixbuf-2.0 -I%PREFIX%\Library\include\pango-1.0 -I%PREFIX%\Library\include\gio-win32-2.0 -I%PREFIX%\Library\include\glib-2.0 -I%PREFIX%\Library\lib\glib-2.0\include -I%PREFIX%\Library\include\harfbuzz -I%PREFIX%\Library\include -I%PREFIX%\Library\include\libxml2 /Tc%SRC_DIR%\win32\tmp-introspect61xdf5zg\Rsvg-2.0.c /Fo%SRC_DIR%\win32\tmp-introspect61xdf5zg\Rsvg-2.0.obj -wd4996 -utf-8
Rsvg-2.0.c
g-ir-scanner: link: link.exe -out:%SRC_DIR%\win32\tmp-introspect61xdf5zg\Rsvg-2.0.exe %SRC_DIR%\win32\tmp-introspect61xdf5zg\Rsvg-2.0.obj -libpath:.\vs15\release\x64 -libpath:%PREFIX%\Library\lib -libpath:%BUILD_PREFIX%\Library\bin rsvg-2.0.lib libxml2.lib /libpath:D:/bld/librsvg_1616611590811/_h_env/Library/lib pango-1.0.lib gio-2.0.lib intl.lib iconv.lib shlwapi.lib dnsapi.lib iphlpapi.lib ws2_32.lib gmodule-2.0.lib intl.lib iconv.lib fribidi.lib fontconfig.lib xml2.lib iconv.lib z.lib cairo.lib gobject-2.0.lib intl.lib iconv.lib ffi.lib harfbuzz.lib usp10.lib gdi32.lib rpcrt4.lib freetype.lib png16.lib z.lib m.lib z.lib graphite2.lib glib-2.0.lib intl.lib iconv.lib pcre.lib ws2_32.lib winmm.lib
Microsoft (R) Incremental Linker Version 14.16.27045.0
Copyright (C) Microsoft Corporation.  All rights reserved.

LINK : fatal error LNK1181: cannot open input file 'm.lib'
linking of temporary binary failed: Command '['link.exe', '-out:D:\\bld\\librsvg_1616611590811\\work\\win32\\tmp-introspect61xdf5zg\\Rsvg-2.0.exe', 'D:\\bld\\librsvg_1616611590811\\work\\win32\\tmp-introspect61xdf5zg\\Rsvg-2.0.obj', '-libpath:.\\vs15\\release\\x64', '-libpath:D:\\bld\\librsvg_1616611590811\\_h_env\\Library\\lib', '-libpath:D:\\bld\\librsvg_1616611590811\\_build_env\\Library\\bin', 'rsvg-2.0.lib', 'libxml2.lib', '/libpath:D:/bld/librsvg_1616611590811/_h_env/Library/lib', 'pango-1.0.lib', 'gio-2.0.lib', 'intl.lib', 'iconv.lib', 'shlwapi.lib', 'dnsapi.lib', 'iphlpapi.lib', 'ws2_32.lib', 'gmodule-2.0.lib', 'intl.lib', 'iconv.lib', 'fribidi.lib', 'fontconfig.lib', 'xml2.lib', 'iconv.lib', 'z.lib', 'cairo.lib', 'gobject-2.0.lib', 'intl.lib', 'iconv.lib', 'ffi.lib', 'harfbuzz.lib', 'usp10.lib', 'gdi32.lib', 'rpcrt4.lib', 'freetype.lib', 'png16.lib', 'z.lib', 'm.lib', 'z.lib', 'graphite2.lib', 'glib-2.0.lib', 'intl.lib', 'iconv.lib', 'pcre.lib', 'ws2_32.lib', 'winmm.lib']' returned non-zero exit status 1181.
NMAKE : fatal error U1077: 'D:\bld\librsvg_1616611590811\_build_env\python.EXE' : return code '0x1'
Stop.

This MR fixes this issue by ensuring that m.lib will get filtered out of the output generated by calling pkg-config --libs --msvc-syntax.

Merge request reports