Skip to content

Draft: Use libadwaita widgets and fix styling

Christopher Davis requested to merge BrainBlasted/gnome-text-editor:wip/cdavis/use-libadwaita-widgets into master

libadwaita provides a few convenient widgets for us that we can use to replace custom widgetry or make things more polished. In this case, I've:

  • Changed the empty page to use AdwStatusPage for consistent styling
  • Ported the Preferences window to AdwPreferencesWindow, which gives us easy sections and the potential for easy search in the future.
  • Exchanged EditorPreferencesRow for AdwActionRow. AdwActionRow does everything we needed EditorPreferencesRow for, and comes with the benefit of consistent styling automatically.
  • Used AdwClamp to prevent the widgets from scaling forever in the language dialog and the .content style class for the list.

This MR also brings a couple misc. style changes to match the HIG and the mockups:

  • GtkSearchBar is used for the search bar, bringing the styling from the mockups to life
  • GtkHeaderBar is used to make the titlebar of the language dialog match the mockups
  • margins are multiples of 6px

One thing to consider before merging: libadwaita may not be ready before GNOME 40 is released, so you may not want to merge yet it you are targeting 40. CC: @exalm

Edited by Christopher Davis

Merge request reports