"Bold color" ignored when "bold is bright" is off
@egmontkob
Submitted by Egmont Koblinger Link to original bug (#792501)
Description
From https://bugzilla.xfce.org/show_bug.cgi?id=14127#c3:
When the new API option "Show bold text in bright colors" is disabled (the new behavior), "Bold color" (the color to use when the default color is turned bold) is ignored.
Depending our philosophy, there's two approaches we could take:
Technically, we could easily keep "Bold color" working in this case too. And if that's the decision then it's a minor VTE change required (move the "&& m_bold_is_bright" condition three lines down to the inner "else" branch).
I'd probably prefer not to restore this behavior, though, as it would go against the intent of the new API, the total separation between boldness and color.
If we decide on keeping the current approach, a followup g-t change should be desirable when the off state of "bold is bright" makes the "bold color" option disabled. And then it's unfortunate that they're in the unnatural order, maybe the new option should be moved up... where exactly? to the very top of the page? Or we'll just revise it with the planned big color scheme refacting...
(The intrinsic problem is: just as "bold is bright" is a legacy compatibility feature, "bold color" is also one and IMHO ideally it shouldn't exist.)
Version: git master
Resolution: RESOLVED FIXED