tab navigation enhancement
Submitted by fafhrd
Assigned to Havoc Pennington
Link to original bug (#106289)
Description
"Next tab" on last tab activate first tab and "Previous tab" on first tab activate last tab
here patch
diff -urN gnome-terminal.orig/src/terminal-window.c gnome-terminal/src/terminal-window.c --- gnome-terminal.orig/src/terminal-window.c 2003-01-05 11:32:29.000000000 +0600 +++ gnome-terminal/src/terminal-window.c 2003-02-17 12:56:53.000000000 +0600 @@ -1128,10 +1132,6 @@ notebook = window->priv->notebook; page_num = gtk_notebook_get_current_page (GTK_NOTEBOOK (notebook));
- gtk_widget_set_sensitive (window->priv->previous_tab_menuitem,
-
page_num > 0);
- /* FIXME
- http://bugzilla.gnome.org/show_bug.cgi?id=73229 */ @@ -1143,9 +1143,7 @@ gtk_widget_set_sensitive (window->priv->close_tab_menuitem, FALSE); else gtk_widget_set_sensitive (window->priv->close_tab_menuitem, TRUE);
- gtk_widget_set_sensitive (window->priv->next_tab_menuitem,
-
!on_last_page);
}
static void @@ -2463,14 +2461,34 @@ next_tab_callback(GtkWidget *menuitem, TerminalWindow *window) {
- gtk_notebook_next_page (GTK_NOTEBOOK (window->priv->notebook));
- gint page_num, n_pages;
- n_pages = gtk_notebook_get_n_pages (GTK_NOTEBOOK (window->priv->notebook));
- page_num = gtk_notebook_get_current_page(GTK_NOTEBOOK (window->priv->notebook));
- if (page_num < n_pages-1) {
- gtk_notebook_next_page (GTK_NOTEBOOK (window->priv->notebook));
- } else {
- gtk_notebook_set_current_page (GTK_NOTEBOOK (window->priv->notebook), 0);
- } }
static void previous_tab_callback (GtkWidget *menuitem, TerminalWindow *window) {
- gtk_notebook_prev_page (GTK_NOTEBOOK (window->priv->notebook));
- gint page_num;
- page_num = gtk_notebook_get_current_page(GTK_NOTEBOOK (window->priv->notebook));
- if (page_num) {
- gtk_notebook_prev_page (GTK_NOTEBOOK (window->priv->notebook));
- } else {
- gint n_pages;
- n_pages = gtk_notebook_get_n_pages (GTK_NOTEBOOK (window->priv->notebook));
- gtk_notebook_set_current_page (GTK_NOTEBOOK (window->priv->notebook), n_pages-1);
- } }
static void
Version: 2.2.x
Resolution: RESOLVED DUPLICATE