Skip to content

packagekit: Ensure PkClient::interactive flag being set

Milan Crha requested to merge wip/mcrha/packagekit-ensure-interactive-flag into main

That's required to properly ask or not ask for the root credentials on operations, which require higher privileges. It's important to set the flag always before the call to the PkTask/PkClient API, because other thread could change the value while the corresponding lock was released by the execution thread.

Downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=2003365

===================================================================

For the reproducer, one can install/remove PackageKit software before a non-interactive task is executed (like the get-updates/get-upgrades), after which the PkTask/PkClient will have set the value from the previous call/thread and use that instead of the current interactive flag for the plugin call.

Merge request reports