Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 233
    • Issues 233
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !913

gs-details-page: Ensure the reviews box is hidden if empty

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gnome-software:1376-reviews-heading into main Aug 12, 2021
  • Overview 1
  • Commits 3
  • Pipelines 1
  • Changes 2

It’s possible for all the children of the box to be hidden or empty for various reasons. If so, hide the outer box, which ensures that the ‘Reviews’ header is hidden.

The list_box_reviews is never hidden, but can be empty, hence the check for reviews->len > 0.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Fixes: #1376 (closed)

Closes #1376 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1376-reviews-heading