Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 251
    • Issues 251
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !472

gs-common: Don’t leak GtkCssProvider for custom CSS

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/gnome-software:css-providers into master Jun 08, 2020
  • Overview 4
  • Commits 2
  • Pipelines 2
  • Changes 7

While the old providers weren’t leaked, they were never used again and their resources were never freed, so they were effectively leaked. In particular, their resources included loaded images for GsFeatureTile backgrounds, which were quite large pixbufs.

This reduces gnome-software’s pixbuf heap consumption from 47MB to 23MB after loading. The previous consumption was so high due to refreshing featured tile CSS a few times during setup.

Signed-off-by: Philip Withnall withnall@endlessm.com

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: css-providers