Skip to content

Backport !2016 “gs-hardware-support-context-dialog: Initialize relation_comparand variable” to gnome-46

Philip Withnall requested to merge pwithnall/gnome-software:backport-2016-relation-comparisons-gnome-46 into gnome-46

It can be left uninitialized in some cases, thus set it some sane values, rather than comparing with unpredictable values.

This had been discovered by a Coverity Scan:

gnome-software-46.1/src/gs-hardware-support-context-dialog.c:462:4: var_decl: Declaring variable "relation_comparand" without initializer. gnome-software-46.1/src/gs-hardware-support-context-dialog.c:506:4: uninit_use_in_call: Using uninitialized value "relation_comparand.max" when calling "evaluate_display_comparison". gnome-software-46.1/src/gs-hardware-support-context-dialog.c:506:4: uninit_use_in_call: Using uninitialized value "relation_comparand.min" when calling "evaluate_display_comparison". 504| } 505| 506|-> if (evaluate_display_comparison (display_lengths[AS_DISPLAY_LENGTH_KIND_SMALL], comparator, relation_comparand)) { 507| *mobile_relation_kind_out = max_relation_kind (*mobile_relation_kind_out, as_relation_get_kind (relation)); 508| *mobile_match_out = TRUE;

Trivial backport of !2016 (merged) to gnome-46.

Merge request reports