gs-plugin-appstream/flatpak: Simplify XbSilo locking

Instead of holding RW lock on the internal silo variable, simply return a reference to it and work with it like with an immutable object. That simplifies locking and makes the code cleaner. It can also make the code quicker, in some cases.