Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-software gnome-software
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 232
    • Issues 232
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-softwaregnome-software
  • Merge requests
  • !1228

gs-feature-tile: Correct narrow mode switch on width change

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Milan Crha requested to merge wip/feature-tile-narrow-mode into main Feb 23, 2022
  • Overview 10
  • Commits 1
  • Pipelines 4
  • Changes 1

The GtkButton::size_allocate() is not called at all, thus the narrow mode switch did not work. The way to do it in gtk4 is to use a GtkLayoutManager. Unfortunately, the GtkBinLayout is not a derivable type, thus this copies it into the sources and adds the narrow mode code into the allocate() method.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/feature-tile-narrow-mode