Cancellation issues in details page
Issue 1:
If an app (e.g. org.gnome.Weather
) is clicked in the Overview
page, and immediately back ( <
) button in top left is pressed, the request is treated as cancelled. But when another app (e.g. org.gnome.Builder.desktop
) is clicked immediately, this cancellable
( in plugin-loader ? ) is passed to the next clicked app, and the following log is printed
failed to refine org.gnome.Builder.desktop: Operation was cancelled
rather than
failed to refine org.gnome.Weather: Operation was cancelled
which I think is not right. This is hidden by 5662c799, so the reverted patch needs to be applied to reproduce this.
Issue 2:
In gs_details_page_load_stage1_cb ()
, after checking the return value from gs_plugin_loader_job_action_finish ()
, we don't return;
if the refine job really failed (not cancelled).
Is this expected ?