regression: Repository name overwritten
Just noticed that I have several similarly looking fedora-repos
rows under Software Repositories dialog and when I revert back a month then it shows (as expected) Fedora 35 - x86_64
and other nice looking names.
I do not know which commit does this, but I see the fancy name being overwritten from here:
Thread 35 "pool-org.gnome." hit Breakpoint 1, gs_app_set_name (app=0x7fff6400d100 [GsApp],
quality=GS_APP_QUALITY_LOWEST, name=0x7fff6402b700 "fedora-repos") at ../lib/gs-app.c:1484
(gdb) p priv->name
$2 = (gchar *) 0x7fff64022160 "Fedora 35 - x86_64 - Updates"
(gdb) bt
#0 gs_app_set_name (app=0x7fff6400d100 [GsApp], quality=GS_APP_QUALITY_LOWEST, name=0x7fff6402b700 "fedora-repos") at ../lib/gs-app.c:1484
#1 0x00007fffc80aa1c1 in gs_plugin_packagekit_set_metadata_from_package (plugin=0x9251c0 [GsPluginPackagekit], app=0x7fff6400d100 [GsApp], package=0x7fff6410fe70 [PkPackage]) at ../plugins/packagekit/packagekit-common.c:404
#2 0x00007fffc80a2176 in search_files_cb (source_object=0x8aa4d0 [PkClient], result=0x7fff64112730, user_data=0x0) at ../plugins/packagekit/gs-plugin-packagekit.c:1870
#3 0x00007ffff7d0d181 in g_simple_async_result_complete (simple=0x7fff64112730 [GSimpleAsyncResult]) at ../gio/gsimpleasyncresult.c:802
#4 0x00007ffff7d0d1cd in complete_in_idle_cb (data=0x7fff64112730) at ../gio/gsimpleasyncresult.c:814
#5 0x00007ffff7af2f80 in g_idle_dispatch (source=0x7fff6464d500, callback=0x7ffff7d0d19a <complete_in_idle_cb>, user_data=0x7fff64112730) at ../glib/gmain.c:5910
#6 0x00007ffff7aefcd6 in g_main_dispatch (context=0x7fff64008a40) at ../glib/gmain.c:3394
#7 0x00007ffff7af0f26 in g_main_context_dispatch (context=0x7fff64008a40) at ../glib/gmain.c:4112
#8 0x00007ffff7af111e in g_main_context_iterate (context=0x7fff64008a40, block=1, dispatch=1, self=0xfb6a40) at ../glib/gmain.c:4188
#9 0x00007ffff7af1258 in g_main_context_iteration (context=0x7fff64008a40, may_block=1) at ../glib/gmain.c:4253
#10 0x00007ffff7f84ba3 in run_refine_filter
(self=0x7fffd00721e0 [GsPluginJobRefine], plugin_loader=0x887360 [GsPluginLoader], list=0x7fff648f0140 [GsAppList], refine_flags=9571584, cancellable=0xd02c20 [GCancellable], error=0x7fff6dd53830)
at ../lib/gs-plugin-job-refine.c:206
#11 0x00007ffff7f84db3 in run_refine_internal (self=0x7fffd00721e0 [GsPluginJobRefine], plugin_loader=0x887360 [GsPluginLoader], list=0x7fff648f0140 [GsAppList], flags=9571584, cancellable=0xd02c20 [GCancellable], error=0x7fff6dd53830)
...
This is a workaround, but I do not propose it as a fix, because it was not needed before, thus it should not be needed now as well.