GS_PLUGIN_REFINE_FLAGS_DEFAULT means no refine
While working on !851 (merged) I noticed using GS_PLUGIN_REFINE_FLAGS_DEFAULT
means no refine being called at all. When I look at gs_plugin_loader_process_thread_cb
, there's:
/* run refine() on each one if required */
if (gs_plugin_job_get_refine_flags (helper->plugin_job) != 0) {
where the GS_PLUGIN_REFINE_FLAGS_DEFAULT
evaluates to 0, thus using that flag means no refine being called for GS_PLUGIN_ACTION_REFINE
.
I'd either set a special/unused value for the GS_PLUGIN_REFINE_FLAGS_DEFAULT
or change the test of the need for the refine call above, to be able to call the refine without specifying any extra value.
Edited by Milan Crha