Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
G
gnome-shell
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,257
    • Issues 1,257
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 103
    • Merge Requests 103
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-shell
  • Merge Requests
  • !858

Merged
Opened Nov 25, 2019 by Benjamin Berg@bbergDeveloper

data: Enable clean session shutdown after gnome-shell failure

  • Overview 15
  • Commits 2
  • Pipelines 26
  • Changes 2

If the GNOME shell crashes, we run a service that may disable extensions. This is important so that users will not be locked out of their own session in case an extension is causing crashes.

As this is a very agressive action, we only do so if the session fails in the first two minutes. The logic to do so was broken though, and would result in an unclean session shutdown.

Fix this by using the newly introduced file %t/gnome-session-stable and using a ConditionPathExists. This avoids any depenencies and therefore can cleanly run in parallel to a normal session shutdown.

Note that it is not a regression to do this even if the gnome-session part is not yet installed on the system. The result will be to always disable the extensions rather than just in the first two minutes.

However, due to a bug in the old logic, this was happening anyway.

See gnome-session!31 (merged)

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: GNOME/gnome-shell!858
Source branch: benzea/systemd-clean-shutdown-with-extension-disabling