Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 1,835
    • Issues 1,835
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 135
    • Merge requests 135
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !559

this.actor removal: Inherit all UI objects from Widgets or Actors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Trevisan requested to merge 3v1n0/gnome-shell:this.actor-removal into master May 28, 2019
  • Overview 160
  • Commits 24
  • Pipelines 185
  • Changes 73

Together with !500, this removes all the this.actor usage in the gnome-shell code.

  • Inherit all the objects from Clutter.Actor's or St.Widget's
  • In some cases, introduced new Interfaces that are implemented by various classes (AppView)
  • fixed some issues we had caused by accessing to "destroyed" classes after their finalization.
  • Ported some other classes to inherit from GObject when we needed to pass them through signaling

I've split the MR in atomic commits, so in theory this could also be split in multiples MRs.

Edited Aug 09, 2019 by Marco Trevisan
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: this.actor-removal