Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2,073
    • Issues 2,073
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 161
    • Merge requests 161
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !536

St theme: use css instance data

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Marco Trevisan requested to merge 3v1n0/gnome-shell:st-theme-use-css-instance-data into main May 07, 2019
  • Overview 18
  • Commits 11
  • Pipelines 26
  • Changes 13

Remove files_by_stylesheet hashtable usage while take advantage of the CRStyleSheet's app_data field to save stylesheet related informations such as the parent GFile and whether this is an extension style-sheet.

So reduce the hashtable lookups and use direct access to data. Then simplify memory management using simpler ref/unref'ing.

Last commits is somewhat optional, but makes things a bit cleaner to my eyes (while I've removed the commit 3v1n0/gnome-shell@531267c9 which was somewhat more needed in the previous revision of the MR where I was still using the custom_stylesheets list).

Edited Jul 18, 2021 by Florian Müllner
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: st-theme-use-css-instance-data