Skip to content

dash: Fix messed up icon height

Florian Müllner requested to merge fmuellner/gnome-shell:ghost-icon into master

When determining the biggest icon size that fits the available height, we first subtract the additional space requirements of icons (spacing, padding, running indicator etc.) and then divide the result by the number of icons to get the maximum size available to each icon texture.

In the above, the additional space requirement of each icon is taken from the first icon (as all icons are assumed to be the same), and calculated as the difference between the icon button's preferred height and the currently used icon size.

To make sure that the icon is actually using the dash's current icon size (even while animating to a new icon size), we enforce its height during the size request and restore its original height afterwards.

However after some recent changes, that step is causing troubles: For some reason, the original height may be 0, and when we restore it, we end up forcing a fixed non-height that bypasses the regular size request machinery.

While it is unclear where exactly the zero height comes from (maybe waiting for a valid resource scale?), it is clear that it's best to avoid forcing a fixed height. So instead of making the icon texture comply with the assumed icon size, adjust the calculations to use its current height request.

Fixes #1053 (closed)

Merge request reports