Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-shell gnome-shell
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 2.1k
    • Issues 2.1k
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 147
    • Merge requests 147
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-shellgnome-shell
  • Merge requests
  • !332

dnd: Repick target actor if destroyed mid iteration

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Jonas Ådahl requested to merge jadahl/gnome-shell:wip/repick-dnd-target-actor into master Jan 03, 2019
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

The picked target actor may be destroyed (e.g. hover style change resulting in the ClutterTexture to be destroyed). If we don't handle this, GJS will abort when it sees the exception caused by Javascript code trying to access the destroyed target actor.

To handle it, listen on the 'destroy' signal on the target actor, and repick, so a valid actor is passed to the next motion callback.

Fixes: #632 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/repick-dnd-target-actor