Skip to content

st/texture-cache: Always close GdkPixbufLoader before disposal

Barnabás Pőcze requested to merge pobrn/gnome-shell:always_close_GdkPixbufLoader into main 
As per the warning emitted when destroying without closing first

  GdkPixbufLoader finalized without calling gdk_pixbuf_loader_close() - this is not allowed.
  You must explicitly end the data stream to the loader before dropping the last reference.

closing it is necessary.

Create the GdkPixbufLoader after loading the file contents so that
the loader is guaranteed to be closed before it is destroyed.
(`gdk_pixbuf_loader_write()` closes it on failure.)
Edited by Barnabás Pőcze

Merge request reports