Skip to content

notificationDaemon: support file:// or icon theme names for image-path

Marco Trevisan requested to merge 3v1n0/gnome-shell:image-path-hint-parsing-fix into master

While this sounds counter-intuitive, the image-path hint value might also be used with URIs or icon names.

As per freedesktop standard:

The "app_icon" parameter and "image-path" hint should be either an URI (file:// is the only URI schema supported right now) or a name in a freedesktop.org-compliant icon theme (not a GTK+ stock ID).

Thus the image-path hint should also be parsed as it happens for the app_icon.

Reuse same logic, by falling back on _iconForNotificationData with the hint value.

--

This could help for testing too libnotify!4 (merged)

This would break the usage of relative paths, I guess it's fine to do it, but if we have cases we care about, maybe it could be changed.

Edited by Marco Trevisan

Merge request reports