Skip to content

dnd: don't try to access destroyed dragActor

Ray Strode requested to merge wip/fix-drag-lock-up into master

The dragComplete handler incorrectly checks this._actorDestroyed to see if the drag actor is destroyed. The drag actor may not be the same as the main actor.

The end result is an exception in drop handling, leading to a shell lockup.

This commit changes the code to always set this._dragActor to undefined when it's destroyed, and check for that condition instead of this._actorDestroyed in the dragComplete handler.

Closes #577 (closed)

Merge request reports