Skip to content

panel: Keep prefs in sync with shell-shows-app-menu state

Jonas Ådahl requested to merge jadahl/gnome-shell:wip/shell-shows-app-menu-prefs into master

Previously mutter listened to Xsettings (via GTK) to get notified whether the shell showed the app menu. After X11 support was changed in the direction of being less central, listening to this particular Xsettings were removed with the intention of having the Shell tell mutter directly whether it was showing the menu or not.

This commit makes that happen. It still travels through Xsettings (still via Gtk), as the shell still gets that state from Xsettings, but fixing this is out of scope for this particular fix.

Closes: mutter#276 (closed)

This is arguably a bit ugly, but for now we seem to be a bit stuck with Xsettings, because that is where this state is communicated. We could teach gnome-shell about /org/gnome/settings-daemon/plugins/xsettings/overrides having it parse those, but if app menus are going a way, maybe we can remove this in time anyway, I don't know.

Merge request reports