Skip to content

WIP: st/theme-node-drawing: Add an optimized path for background-color

Daniel van Vugt requested to merge vanvugt/gnome-shell:quick-background-color into master

This is used for styles that are a simple background-color with no borders and saves a few milliseconds in render time, particularly as it applies to overviewGroup.

When combined with !1843 (closed) this practically eliminates the performance penalty of theme node painting, making it just as fast as commenting out st_widget_paint_background entirely. That's to say halving the render time of the overview (at 4K on an i7-7700) from 21ms avg + 27ms peak to 10ms avg + 14ms peak.

FIXME:

  • Still some occasional glitches. I suspect cogl's framebuffer clipping functions are faulty (?)
  • Aggregate menu dividers are in the wrong place (a problem that !1849 (closed) does not have).
Edited by Daniel van Vugt

Merge request reports