Skip to content

[3.38] polkitAgent: Ensure cleanup if dialog wasn't shown

Jonas Ådahl requested to merge cherry-pick-21faae48 into gnome-3-38

It is possible for an initiated session to complete without a request if polkit can authenticate the action without user input. We fail to clean up after ourselves in that case, as the cleanup is done after the dialog is closed.

The dialog can still be shown when the code that hides existing dialogs while the screen is locked shows it on unlock. But as the session was closed, the dialog is now defunct and cannot be dismissed by the user.

Fix this by running the cleanup on close() when the dialog wasn't shown.

#3701 (closed)

Part-of: !1662 (merged)

(cherry picked from commit 21faae48)

Merge request reports