Skip to content

shell-mime-sniffer: Ignore invalid file content type

Marco Trevisan requested to merge 3v1n0/gnome-shell:sniffer-handle-invalid-mimetype into master

The shell mime sniffer goes through all the files in a directory, however in case a file content type is not recognized, the GIO function g_file_info_get_content_type() may return NULL, causing a crash when looking up into the content type tables, as they are supposed to contain strings only and they use g_str_hash has func, which doesn't support NULL values.

So, in case we get an invalid content type, let's just ignore it, without adding it to the cache as we do in the nautilus code that was inspiring the sniffer.

Fixes #2643 (closed)

Merge request reports