Skip to content

Issue with event listener for keyboard key press events on Modal/Dialog buttons

Blip requested to merge blipk/gnome-shell:patch-1 into master

If keys are being passed as an array it creates a nested array. The first element being the array of keys. The for loop @:146 then only adds one element to _buttonKeys as can be seen in the dump of this.dialogLayout below. This then causes _modalEventHandler to not process any key events.

buttonInfo: { "label": "Done", "key": [ 65293, 65421, 65076 ] }

this.dialogLayout: { "_initialKeyFocus": {}, "_initialKeyFocusDestroyId": 25782, "_pressedKey": null, "_buttonKeys": { "65293,65421,65076": { "label": "Done", "key": [ 65293, 65421, 65076 ], "button": {} } }, "_dialog": {}, "contentLayout": {}, "buttonLayout": {}, "_parentActor": {}, "_eventId": 25689 }

Merge request reports