Skip to content

authPrompt: Fix spinner alignment

Florian Müllner requested to merge fmuellner/gnome-shell:fix-auth-spinner-align into master

We want the spinner to be centered with regard to the entry, but constraining the height breaks that:

  1. clutter_actor_allocate() is called with the available size
  2. clutter_actor_update_constraints() then adjusts that according to the constraints
  3. clutter_actor_adjust_allocation() applies the margin/expand/align properties.

The issue there is that 2. reduces the allocation to the desired size, so there is no more extra space to distribute in 3.

We can fix this by either constraining everything (and rely on the cancel button's alignment) or limit the constraint to the width. The latter seems more appropriate, given that the constraint is only used to center the entry horizontally.

Fixes #2628 (closed)

Edited by Florian Müllner

Merge request reports