Skip to content

st/texture-cache: Fix invalid memory write related to X11 window icons

Sebastian Keller requested to merge skeller/gnome-shell:st-texture-cache-invalid-write into master

st_texture_cache_bind_weak_notify calls g_clear_signal_handler which then calls st_texture_cache_free_bind. st_texture_cache_free_bind frees the bind structure, so by the time g_clear_signal_handler tries to write bind->notify_signal_id, bind has already been freed.

Fix this by using g_signal_handler_disconnect instead.

This partially reverts 135d178d

Fixes #2334 (closed)

Merge request reports