Skip to content

thumbnail-factory: Simplify code

Debarshi Ray requested to merge wip/rishi/thumbnailer-factory-single-mutex into master

Tie the lifetime of the PhotosThumbnailerDBus proxy even more tightly to that of the GDBusConnection, so that only one GMutex is enough.

As a nice side-effect, this addresses a race when handling errors from GenerateThumbnail, if the GCancellable had been triggered in the application and the thumbnailer process had crashed. Earlier, it was possible for the GDBusConnection to have been destroyed and set to NULL due to the crash before mutex_connection could be locked.

Merge request reports