WIP: Core rework
This is VERY MUCH a non-functional proof of concept.
Only AlbumWidget in AlbumsView is somewhat ported.
This is the direction I would like to go, to really solve a lot of our problems. This will be quite the undertaking if we want to proceed further.
Update june 26
This is now pretty much functional for album and artist view. The other views are broken.
Update june 27
Songs view is working.
Update juli 1
Searchview is in it's basic state working. No searches for specific attributes implemented yet.
Update juli 8
All views are working to some extent, functionality has been gutted at places for porting. It is in a testable state. Please do report problems.
Issues
- General
-
Activating a song resets all state (played) on the current view.
Grilo
-
Source removal is not handled (mainly important online sources) -
Large scale additions/removals are inefficiently handled and lock up. -
CoreArtist
not updated on changes (ArtistsView
) -
CoreDisc
not updated on changes (discs stay around)
AlbumWidget
-
_listbox
border becomes black if the album has a lot of songs (scroll view issue?) -
disc label color changes on hover -
hard to distinguish disc label from songs titles -
ellipsize issue when the song title is too long? -
adding songs to an existing playlist does not work (crash)
AlbumsView
-
adding songs to an existing playlist does not work (crash)
ArtistsView
-
the first artist is not selected by default -
SongWidget
does not respect new style (https://gitlab.gnome.org/Teams/Design/app-mockups/blob/master/music/music-list-style.png)-
SongWidget
is too wide () -
Disc number should be hidden if there is only one disc -
Artist name should not be visible -
Album title should be bigger
-
SearchView
-
Does not search anything beyond Tracker at this point -
Add generic search for any source that supports search
-
-
Not sure if it updates on changes
PlayerToolbar
-
restarts at zero when leaving pause
Player
-
Shuffle needs improvement -
No discovery, is it still needed for something? -
If the URL does not exist they player just stops and does nothing (does not skip)
Edited by Marinus Schraal