Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gnome-music
gnome-music
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 113
    • Issues 113
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 31
    • Merge Requests 31
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-musicgnome-music
  • Merge Requests
  • !19

Merged
Opened Jan 06, 2018 by Marinus Schraal@mschraalMaintainer

albumartcache rewrite

  • Overview 0
  • Commits 6
  • Pipelines 23
  • Changes 16

The idea is that we just pass a GtkImage + size + media info to the Art class and it updates the image when it is retrieved. This is a bit more involved for treeviews which do not update without explicitly forcing the update on the cellrenderer and actually only take a GdkPixbuf right now.

This cleans a lot of logic from the views.

update

With the intial rework I ran into some problem that were caused by the complicated nature of AlbumArtCache. So split up the logic and implement it more modular and cleanly. I also added a queue for all the types of lookups, like we had before for the iobound lookups.

update (23 january)

More cleanup & rework. Now supports HiDPI images in the searchview (Gtk.TreeView) and does a local lookup for covers in the album directory again (I missed this on the inital rewrite).

update (29 january)

This should be about stable. Added a smooth transition to coverswitching for gtk images.

Edited Jan 28, 2018 by Marinus Schraal
Assignee
Assign to
Reviewer
Request review from
3.27.90
Milestone
3.27.90 (Past due)
Assign milestone
Time tracking
Reference: GNOME/gnome-music!19
Source branch: wip/mschraal/artrework