Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • gnome-maps gnome-maps
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 146
    • Issues 146
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 5
    • Merge requests 5
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-mapsgnome-maps
  • Merge requests
  • !24

'Create a favorite' feature

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Sumaid requested to merge Sumaid/gnome-maps:favorite_contextoption into master Jan 13, 2019
  • Overview 12
  • Commits 1
  • Pipelines 3
  • Changes 10

New Feature Added: "Context menu will have an option 'Create a favorite' which will ask for the name of favorite in a dialog box, and that location will be stored as a favorite location with the given name."

Files Modified: 1)context-menu.ui 2)contextMenu.js 3)favoriteEditDialog.js(New File) 4)zoominFavoriteDialog.js(New File) 5)org.gnome.Maps.src.gresource.xml 6)zoom-in-favorite-dialog.ui 7)favorite-edit-dialog.ui 8)org.gnome.Maps.data.gresource.xml

New Feature Added: Issue #144 Not all streets/roads have their street numbers defined in OpenStreetMap so, on a back road in the middle of nowhere, you can't create a favorite at an exact location. I suggest to add a "Create favorite" in the context menu when we right-click on a specific point on the map, which would pick the exact GPS coordinate of the point where we right click and create a favorite based on these coordinates.

Overview of the fix: The fix is designed using the OSM edit dialog files as reference.

#144

Edited Jan 13, 2019 by Sumaid
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: favorite_contextoption