Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G gnome-keyring
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-keyring
  • Merge requests
  • !50

gkm: Fix some format-truncation warnings

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Niels De Graef requested to merge nielsdg/fix-snprintf-truncation-warning into master May 21, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

When enabling fatal warnings (like in our CI), the -Werror=format-truncation= flag is complaining about us using snprintf() in a way that can theoretically truncate its arguments, even though this will not happen in practice, unless people are still running gnome-keyring in the year 100000.

Solve the warning by doing a dumb check that aborts if snprintf returns an error

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: nielsdg/fix-snprintf-truncation-warning