Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G gnome-keyring
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • gnome-keyring
  • Merge requests
  • !38

Default "automatically unlock" checkbox to false

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Ryan Hendrickson requested to merge rhendric/gnome-keyring:fix-7 into master May 20, 2021
  • Overview 4
  • Commits 1
  • Pipelines 6
  • Changes 1

The GCR prompt used to unlock keyrings and other secure objects has a checkbox for automatically unlocking the object when the user logs in. Previously, this checkbox was checked by default if the object in question had the CKA_GNOME_TRANSIENT attribute set. This linkage frankly makes no sense; the change can be traced back to a nine-year-old commit (084ce5e0) which appears to have mistakenly altered code that used CKA_GNOME_TRANSIENT to determine the nature of the choice into code that used CKA_GNOME_TRANSIENT to set the default value of the choice.

Defaulting this checkbox to true, which was the practical effect of using CKA_GNOME_TRANSIENT in this way, has obvious drawbacks for security, as the reporter of #7 and the various reporters in bugs linked from there have attested.

Removing this linkage is a small change, but it results in a larger amount of code being no longer needed, which this commit cleans up.

Fixes #7.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-7