Skip to content

Connect to GDM as soon as gnome-initial-setup starts and fix memory leaks

João Paulo Rechi Vita requested to merge jprvita/gnome-initial-setup:connect-to-gdm-on-start into master

GDM can't tell Plymouth to quit until gnome-initial-setup connects to it, so GDM knows gnome-initial-setup has started successfully. Currently gnome-initial-setup only connects to GDM once the user clicks the "Start Using $DISTRO" button on the last page, to switch over to the newly-created user. This prevents accessing the TTY for the whole time gnome-initial-setup is running and makes systemd account the time spent in gnome-initial-setup as part of the boot process.

Connecting to GDM as soon as gnome-initial-setup starts allows GDM to tell Plymouth to quit at the right time, avoiding the problems described above.

Closes: gdm#439 (closed)

While at it, I also fixed a couple of places where a GdmClient and a GError were leaking, removed an unnecessary return statement and made all instances of GError throughout the same file use a g_autoptr.

Merge request reports