Timed backgrounds starts 1 hour early.
Submitted by Olivier Samyn
Assigned to Desktop Maintainers
Link to original bug (#694816)
Description
Just for fun I created a timed background that changes every hour.
After some tests and double checking my setup, I was surprised to see a transition starting 1 hour before I expected it to start.
I checked the code and found an unexpected line in gnome-bg-slide-show.c, in the xml file parsing there is the following conversion:
if (stack_is (self, "hour", "starttime", "background", NULL)) { self->priv->start_tm.tm_hour = parse_int (text) - 1; }
I suppose the 1h off I observed come from this "-1".
From my user point of view, if I put <hour>
00</hour>
in my background xml file, I expect the code to put 0 in tm_hour but it's not the case.