Skip to content

wwan: sound: fix compiler warnings

Pablo Correa Gomez requested to merge pabloyoyoista/gnome-control-center:type-punned-pointer into main

Fix many warnings of the form:

../panels/sound/cc-output-test-wheel.c: In function 'cc_output_test_wheel_dispose':
../panels/sound/cc-output-test-wheel.c:155:20: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
  155 |   g_clear_pointer ((GtkWidget**) &self->front_center_speaker_button, gtk_widget_unparent);
/usr/include/glib-2.0/glib/gmacros.h:870:47: note: in definition of macro 'G_STATIC_ASSERT'
  870 | #define G_STATIC_ASSERT(expr) _Static_assert (expr, "Expression evaluates to false")
      |                                               ^~~~
../panels/sound/cc-output-test-wheel.c:155:3: note: in expansion of macro 'g_clear_pointer'
  155 |   g_clear_pointer ((GtkWidget**) &self->front_center_speaker_button, gtk_widget_unparent);
      |   ^~~~~~~~~~~~~~~

Consequence of casting the pointers during g_clear_pointer. This is also cleaner and requires a lot less casting.

There are a couple more spread around the code, but these are the most relevant ones.

Compiler: gcc 13.2.1 "gcc (Alpine 13.2.1_git20231014) 13.2.1 20231014"

Edited by Pablo Correa Gomez

Merge request reports