Skip to content

mouse: Prevent infinite loop on settings changes

Marco Trevisan requested to merge 3v1n0/gnome-control-center:fix-mouse-two-fingers-loop into main

We may get an infinite loop on mouse panel startup, in fact the scroll method changed event emits a gsettings change that also leads to a notify::use-default emission that again tries to writes to settings, leading to another change: infinitely.

We could avoid this also with a variable check, but let me know what's your favorite approach.

04:03:26.8185                dconf[2528003]:   DEBUG: change_fast
04:03:26.8186                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8186                dconf[2528003]:   DEBUG: change_fast
04:03:26.8186                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8186                dconf[2528003]:   DEBUG: change_fast
04:03:26.8187                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8187                dconf[2528003]:   DEBUG: change_fast
04:03:26.8187                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8187                dconf[2528003]:   DEBUG: change_fast
04:03:26.8188                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8188                dconf[2528003]:   DEBUG: change_fast
04:03:26.8188                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8188                dconf[2528003]:   DEBUG: change_fast
04:03:26.8189                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8189                dconf[2528003]:   DEBUG: change_fast
04:03:26.8189                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8189                dconf[2528003]:   DEBUG: change_fast
04:03:26.8189                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enabled
04:03:26.8190                dconf[2528003]:   DEBUG: change_fast
04:03:26.8190                dconf[2528003]:   DEBUG: change_notify: /org/gnome/desktop/peripherals/touchpad/two-finger-scrolling-enable

Closes: #2405 (closed)

Edited by Marco Trevisan

Merge request reports