multiple panels: make sure exactly one title button set on left/start is visible regardless of leaflet state
requested to merge camelCaseNick/gnome-control-center:camelCaseNick/consistent-title-buttons into main
Currently, Settings is inconsistent with displaying the left title buttons with having anything between zero and two.
Methodology:
- I comprised a list of every AdwHeaderBar in a .ui file.
- I made sure every panel can be displayed in a flatpak build based on !1693 (closed) with a workaround for the mouse panel that failed to init the test dialog and crashed subsequently: cd3482d5
- I checked that the dialog windows have the same value for show-start- and -end-title-buttons. They all did.
- For the panels, I navigated to each one and noted missing or duplicate title buttons and noted a missing back button in the mouse panel.
After applying my changes, I repeated steps 3 and 4 to verify the behaviour is now as expected.
To make sure one left title button and/or one right title button are always visible simultaneously, I tested with close:close:
| folded before | folded after | expanded before | expanded after | |
|---|---|---|---|---|
| Application overview |  |
 |
– | – |
| Application |  |
 |
 |
 |
| Display overview |  |
 |
 |
 |
| Display |  |
 |
 |
 |
| Night Light |  |
 |
 |
 |
| Mouse |  |
 |
 |
 |
| Network |  |
 |
 |
 |
| Accessibility |  |
 |
 |
 |
| Accessibility / Seeing |  |
 |
 |
 |
| User |  |
 |
 |
 |
Not fixed: The title buttons are hidden for the apply header bar of the displays panel, but not the start title buttons of the sidebar. This, however, is only noticeable, if both start and end title buttons are used and not just either one or the other. (Note that the button layout still is close:close for the following screenshots.)
| folded | expanded |
|---|---|
 |
 |
Edited by Markus Göllnitz