Skip to content

object-cache: Avoid use after free of task error

Georges Basile Stavracas Neto requested to merge cherry-pick-f00fd653 into gnome-43

The error should not be touched after passing it to g_task_return_error() as noted by its documentation:

Note that since the task takes ownership of @error, and since the task may be completed before returning from g_task_return_error(), you cannot assume that @error is still valid after calling this.

However, previously, the code did try to free error since the local_error was defined with g_autoptr(GError).

(cherry picked from commit f00fd653)

Merge request reports