Don't generate potentially invalid display configurations
253- /* Enable all usable outputs */
253+ /* Enable all usable outputs
254+ * Note that this might result in invalid configurations as we
Georges Basile Stavracas Neto @feaneron · 1 hour ago
This is pretty terrible :(
Isn't it possible to avoid all invalid configurations, and still have the panel working?
Benjamin Berg @bberg · 1 hour ago
Hmm, I need to think about this again.
In principle, this will never happen. i.e. we should only hit this code path when we have exactly two
monitors, so in practice no one should hit that error. I do need to double check if this might fail
for >2 monitors though.
I would need to check how we can detect this. In principle, it requires counting the number of CRTCs
and number of active monitors; but there are 5k screens that require two CRTCs and there are also cases
where two monitors are connected to the same port (e.g. DP port with build-in HDMI adapter where only
one of them can be used).
btw. doing this is not a regression in principle. This is what the old dialog also did.